search

pmem / pmemstream

Other
9 stars 13 forks source link

Change region_runtime states and function naming #124

Closed igchor closed 2 years ago

igchor commented 2 years ago

to make it more generic. This patch is a preparation for introducing timestamp-based persistency.

This change is Reviewable

codecov-commenter commented 2 years ago

Codecov Report

Merging #124 (fc712e4) into master (055b10a) will decrease coverage by 6.92%. The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   90.71%   83.78%   -6.93%     
==========================================
  Files           8        8              
  Lines         571      549      -22     
==========================================
- Hits          518      460      -58     
- Misses         53       89      +36
Flag Coverage Δ
tests_clang_debug_cpp17 ?
tests_gcc_debug 83.78% <72.22%> (-1.46%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/region.c 75.67% <68.75%> (-17.66%) :arrow_down:
src/iterator.c 84.53% <100.00%> (-8.47%) :arrow_down:
src/libpmemstream.c 88.35% <100.00%> (-0.46%) :arrow_down:
src/id_manager.c 82.85% <0.00%> (-6.19%) :arrow_down:
src/span.c 88.23% <0.00%> (-5.89%) :arrow_down:
src/thread_id.c 77.77% <0.00%> (-2.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 055b10a...fc712e4. Read the comment docs.

igchor commented 2 years ago

@lukaszstolarczuk I actually should have left the "iterate" in function name. Done.