pmem / pmemstream

Other
9 stars 13 forks source link

Don't compile debug function in release mode #129

Closed KFilipek closed 2 years ago

KFilipek commented 2 years ago

This PR uses NDEBUG macro to avoid compilation of some functions in release mode.


This change is Reviewable

codecov-commenter commented 2 years ago

Codecov Report

Merging #129 (0618e7d) into master (31dd2f1) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   91.00%   91.00%           
=======================================
  Files           8        8           
  Lines         556      556           
=======================================
  Hits          506      506           
  Misses         50       50           
Flag Coverage Δ
tests_clang_debug_cpp17 92.26% <100.00%> (ø)
tests_gcc_debug 85.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/id_manager.c 89.04% <ø> (ø)
src/region.c 93.60% <ø> (ø)
src/iterator.c 93.20% <100.00%> (-0.07%) :arrow_down:
src/libpmemstream.c 90.64% <0.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31dd2f1...0618e7d. Read the comment docs.