search

pmem / pmemstream

Other
9 stars 13 forks source link

Add ThreadSanitizer option to CMake #234

Closed KFilipek closed 2 years ago

KFilipek commented 2 years ago

This change is Reviewable

codecov-commenter commented 2 years ago

Codecov Report

Merging #234 (60374c3) into master (cfa5d7c) will increase coverage by 2.49%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   86.26%   88.76%   +2.49%     
==========================================
  Files           9        9              
  Lines         721      721              
  Branches      126      127       +1     
==========================================
+ Hits          622      640      +18     
+ Misses         61       48      -13     
+ Partials       38       33       -5
Flag Coverage Δ
tests_gcc_debug_cpp17 88.76% <ø> (+2.49%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pmemstream/src/iterator.c 94.00% <0.00%> (-0.06%) :arrow_down:
pmemstream/src/libpmemstream_internal.h 100.00% <0.00%> (ø)
pmemstream/src/libpmemstream.c 87.01% <0.00%> (+1.89%) :arrow_up:
pmemstream/src/region.c 86.99% <0.00%> (+8.76%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

KFilipek commented 2 years ago

it looks good, why not enable it in CI (in a separate job), like for ASAN/UBSAN...?

Reviewed 2 of 2 files at r1. Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @KFilipek)

ofc, I can enable it in CI, if it's needed :)