search

pmem / pmemstream

Other
9 stars 13 forks source link

Add libasan/libtsan/libubsan for Fedora 35 #241

Closed KFilipek closed 2 years ago

KFilipek commented 2 years ago

This PR following:

UBSAN:

-- Performing Test C_HAS_UBSAN
-- Performing Test C_HAS_UBSAN - Failed
-- Performing Test CXX_HAS_UBSAN
-- Performing Test CXX_HAS_UBSAN - Failed
--   undefined sanitizer is not supported (neither by C nor CXX compiler)

ASAN:

-- Performing Test C_HAS_ASAN
-- Performing Test C_HAS_ASAN - Failed
-- Performing Test CXX_HAS_ASAN
-- Performing Test CXX_HAS_ASAN - Failed
--   address sanitizer is not supported (neither by C nor CXX compiler)

and TSAN from the previous PR.

Commit:

Due to the lack of sanitizer support in Fedora 35 there is a need to install it manually.

This change is Reviewable

codecov-commenter commented 2 years ago

Codecov Report

Merging #241 (c90ca71) into master (55f925a) will increase coverage by 0.13%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   88.84%   88.98%   +0.13%     
==========================================
  Files           9        9              
  Lines         726      726              
  Branches      127      127              
==========================================
+ Hits          645      646       +1     
  Misses         48       48              
+ Partials       33       32       -1
Flag Coverage Δ
tests_gcc_debug_cpp17 88.98% <ø> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pmemstream/src/libpmemstream.c 87.46% <0.00%> (+0.25%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

karczex commented 2 years ago

utils/docker/images/fedora-35.Dockerfile line 17 at r1 (raw file):


# Install dependency for thread sanitizer
RUN dnf install -y libasan libtsan libubsan

Please do clenup, like here https://github.com/pmem/dev-utils-kit/blob/4331a0549a11d92534e50b52001134ee6309ab26/docker/images/fedora-34.Dockerfile#L78

KFilipek commented 2 years ago

I've created PR: https://github.com/pmem/dev-utils-kit/pull/12