search

pmem / pmemstream

Other
9 stars 13 forks source link

[tests] modify sync cases in timestamp test #248

Closed KFilipek closed 2 years ago

KFilipek commented 2 years ago

Related to #211. ~Depends on: https://github.com/pmem/miniasync/pull/109~

This change is Reviewable

codecov-commenter commented 2 years ago

Codecov Report

Merging #248 (b2be501) into master (13aa782) will decrease coverage by 1.07%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   89.35%   88.27%   -1.08%     
==========================================
  Files           9        9              
  Lines         742      776      +34     
  Branches      134      142       +8     
==========================================
+ Hits          663      685      +22     
- Misses         47       56       +9     
- Partials       32       35       +3
Flag Coverage Δ
tests_gcc_debug_cpp17 88.27% <ø> (-1.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pmemstream/src/libpmemstream.c 86.07% <0.00%> (-1.84%) :arrow_down:
pmemstream/src/region.c 89.06% <0.00%> (ø)
pmemstream/src/libpmemstream_internal.h 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

lukaszstolarczuk commented 2 years ago

you can apply your fix (https://github.com/pmem/miniasync/pull/109) here as a workaround and we can update that later on (when they merge it)