search

pmem / pmemstream

Other
9 stars 13 forks source link

[helpers] move region_runtime find outside loop #252

Closed KFilipek closed 2 years ago

KFilipek commented 2 years ago

There is no need to execute this code multiple times.

This change is Reviewable

codecov-commenter commented 2 years ago

Codecov Report

Merging #252 (6efad34) into master (55f925a) will increase coverage by 0.51%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   88.84%   89.35%   +0.51%     
==========================================
  Files           9        9              
  Lines         726      742      +16     
  Branches      127      134       +7     
==========================================
+ Hits          645      663      +18     
+ Misses         48       47       -1     
+ Partials       33       32       -1
Flag Coverage Δ
tests_gcc_debug_cpp17 89.35% <ø> (+0.51%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pmemstream/src/iterator.c 92.72% <0.00%> (-1.28%) :arrow_down:
pmemstream/src/region.c 88.28% <0.00%> (+0.78%) :arrow_up:
pmemstream/src/libpmemstream.c 88.16% <0.00%> (+0.94%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more