search

pmem / pmemstream

Other
9 stars 13 forks source link

Increase fortification level #272

Closed lukaszstolarczuk closed 2 years ago

lukaszstolarczuk commented 2 years ago

The support for _FORTIFY_SOURCE=3 is available in gcc and clang for some time now. We enable it only in the job running the latest Ubuntu; Fedora currently used in our CI, does not support level > 2 by default and produces a warning.

This change is Reviewable

codecov-commenter commented 2 years ago

Codecov Report

Merging #272 (e5e0b6c) into master (4081d30) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files           9        9           
  Lines         784      784           
  Branches      144      144           
=======================================
  Hits          684      684           
  Misses         63       63           
  Partials       37       37
Flag Coverage Δ
tests_gcc_debug_cpp17 87.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kilobyte commented 2 years ago

Good idea!

The bug report from Fedora was only about the weird way they set the flag; it's good to verify that it actually works.