Closed szadam closed 1 year ago
Merging #283 (890b56c) into master (ad4b618) will decrease coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 87.26% 87.24% -0.02%
==========================================
Files 9 9
Lines 785 784 -1
Branches 144 144
==========================================
- Hits 685 684 -1
Misses 63 63
Partials 37 37
Flag | Coverage Δ | |
---|---|---|
tests_gcc_debug_cpp17 | 87.24% <ø> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pmemstream/src/iterator.c | 91.81% <0.00%> (-0.91%) |
:arrow_down: |
pmemstream/src/region.c | 89.06% <0.00%> (-0.09%) |
:arrow_down: |
pmemstream/src/libpmemstream.c | 84.51% <0.00%> (+0.22%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
README.md
line 27 at r1 (raw file):
I mean: ! DISCONTINUATION... ! (capitals maybe) \- \- \- \`pmemstream\` is a logging .... \#\#Table of....
so, do you mean that I should merge this paragraph with the previous one?
README.md
line 47 at r3 (raw file):
1. `steel` as in Man of Steel? :stuck_out_tongue_winking_eye: 2. I'm not very fond of this sentence - you can ask questions everywhere (on Slack/pmem group/email), so "still have more questions" is not suitable here in my opinion
so just "if you have more questions you can reach..." or maybe just "You can reach out..."?
README.md
line 47 at r3 (raw file):Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote… so just "if you have more questions you can reach..." or maybe just "You can reach out..."?
As I said, questions can be asked in several places, this is just one of them. From my point of view, the second version is better, e.g.:
You can reach us out using the dedicated e-mail: ...
// Preview: https://github.com/szadam/pmemstream/blob/master/README.md#discontinuation-of-the-project
This change is