search

pmem / run_qemu

A script to create bootable OS images, and run qemu with a locally built kernel.
Creative Commons Zero v1.0 Universal
58 stars 22 forks source link

run_qemu.sh: fix the issue related to uncompressing of ZST file #12

Closed jonzhang-fb closed 2 years ago

jonzhang-fb commented 2 years ago

Use zstd to uncompress file with .zst extension, then call tar command to untar it.

Signed-off-by: Jonathan Zhang jonzhang@fb.com

kilobyte commented 2 years ago

You can pipe from zstd to avoid leaving an uncompressed copy on the disk.

jonzhang-fb commented 2 years ago

You can pipe from zstd to avoid leaving an uncompressed copy on the disk.

Makes sense. I updated the patch to use "tar -I" to define how it should be decompressed.

kilobyte commented 2 years ago

Just for the record: tar gained zstd support 4 years ago in 1.31, -I zstd does the trick on versions prior to that.

stellarhopper commented 2 years ago

@jonzhang-fb I'm happy to add -I zstd if it helps support distros with older tars.

jonzhang-fb commented 2 years ago

Hi Vishal, I do not understand why github says I closed this PR. I do not intend to do so. I am not experienced with github PR system however. I have not found a way to reopen it. Maybe you could reopen it and merge it?

jonzhang-fb commented 2 years ago

The "reopen with comment" button made the difference. ;-)

stellarhopper commented 2 years ago

@jonzhang-fb no worries, will merge, thanks!