pmem / run_qemu

A script to create bootable OS images, and run qemu with a locally built kernel.
Creative Commons Zero v1.0 Universal
58 stars 22 forks source link

Building for CXL doesn't respect users qemu environment variable #20

Closed marcj303 closed 2 years ago

marcj303 commented 2 years ago

sudo qemu=/path-to/qemu/build/qemu-system-x86_64 run_qemu.sh --git-qemu --cxl-debug

if [[ $_arg_cxl_legacy == "on" ]] || [[ $_arg_cxl == "on" ]]; then
        _arg_git_qemu="on"
    fi
    if [[ $_arg_git_qemu == "on" ]]; then
        qemu=~/git/qemu/x86_64-softmmu/qemu-system-x86_64
        qemu_img=~/git/qemu/qemu-img
        qmp=~/git/qemu/scripts/qmp/qmp-shell
        # upstream changed where binaries go recently
        if [ ! -f "$qemu_img" ]; then
            qemu=~/git/qemu/build/qemu-system-x86_64
            qemu_img=~/git/qemu/build/qemu-img
        fi
stellarhopper commented 2 years ago

@marcj303 Thanks for the report - yes this needs a clean up. There is some discussion about this in #17 - just need to go make it happen :)

marcj303 commented 2 years ago

Sorry, I didn't see that. This can be closed as a duplicate.