pmem / run_qemu

A script to create bootable OS images, and run qemu with a locally built kernel.
Creative Commons Zero v1.0 Universal
58 stars 22 forks source link

Poorly named memory backend file #3

Closed bwidawsk closed 3 years ago

bwidawsk commented 3 years ago

The file being created here is actually a "window" for possibly more than single type3 device. It can be confusing when seen in the file system, in particular if/when interleave is supported. Something like:

- qcmd+=("-object" "memory-backend-file,id=cxl-mem1,share=on,mem-path=cxl-type3,size=$cxl_backend_size")
+ qcmd+=("-object" "memory-backend-file,id=cxl-mem1,share=on,mem-path=cxl-window1,size=$cxl_backend_size")