search

pmessentials / PMEssentials

A collection of essential PMMP commands, features and more. Heavily inspired by Essentials
GNU General Public License v2.0
11 stars 11 forks source link

[BUG] Size not working + Fix #25

Closed dearminder closed 5 years ago

dearminder commented 5 years ago

Describe the bug /size shows error

To Reproduce Steps to reproduce the behavior:

  1. Use Size command Versions:
    • Any

Fix: Change in PlayerSizeChangeEvent.php

public function __construct(Player $player, CommandSender $sender, float $size)

to public function __construct($player, $sender, $size)

AndreasHGK commented 5 years ago

Whats the error?

dearminder commented 5 years ago

Internal server error, i dont remember but im already making a pull request with this fixed also

AndreasHGK commented 5 years ago

Dont just remove the types. Theres probably something else u can do

dearminder commented 5 years ago

Error 0: Argument 3 passed to pmessentials\PMEssentials\event\PlayerSizeChangeEvent::__construct() must be of the type float, string given, called in /storage/emulated/0/PocketMine-MP/plugins/PMEssentials-master/src/pmessentials/PMEssentials/command/SizeCommand.php on line 55 on line 16 in file /storage/emulated/0/PocketMine-MP/plugins/PMEssentials-master/src/pmessentials/PMEssentials/event/PlayerSizeChangeEvent.php This is what it says

AndreasHGK commented 5 years ago

Alright i’ll fix that

AndreasHGK commented 5 years ago

Should be fixed