pmgbergen / porepy

Python Simulation Tool for Fractured and Deformable Porous Media
GNU General Public License v3.0
252 stars 88 forks source link

Documentation and minor change in the Peaceman well model #1132

Closed keileg closed 9 months ago

keileg commented 9 months ago

Proposed changes

This PR introduce contains a slight modification of the Peaceman well model, and more importantly better documentation of that model. Moreover, the units of some constitutive laws were added.

Consider in particular:

  1. For the specific volume in Peaceman, should we take the volume integral over the interface or the subdomain? It seems the former has the better chance of being correct for 1d-3d couplings, but I am not sure.
  2. Please pay attention to the formatting in the documentation of units. I prefer this style, but if we want changes, it is best to do that now, and define whatever comes out of it as a template. Also, should we always document in SI units, or are derived units (Pa, N etc.) also okay?

Types of changes

What types of changes does this PR introduce to PorePy? Put an x in the boxes that apply.

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.