pmgbergen / porepy

Python Simulation Tool for Fractured and Deformable Porous Media
GNU General Public License v3.0
251 stars 88 forks source link

BUG: Honor is_diverged when progress bars are off #1145

Closed IvarStefansson closed 7 months ago

IvarStefansson commented 7 months ago

Proposed changes

Bug: Missing break of while loop if progress bar are not turned on. Thus, the nonlinear loop continued running.

Types of changes

What types of changes does this PR introduce to PorePy? Put an x in the boxes that apply.

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

IvarStefansson commented 7 months ago

How on earth did this shortcoming survive for so long? Apparently, our simulations usually converge.

Indicates lacking test coverage. Also reveals the vulnerability of the progress bar code...