Closed IvarStefansson closed 7 months ago
Bug: Missing break of while loop if progress bar are not turned on. Thus, the nonlinear loop continued running.
What types of changes does this PR introduce to PorePy? Put an x in the boxes that apply.
x
Put an x in the boxes that apply or explain briefly why the box is not relevant.
pytest
--run-skipped
How on earth did this shortcoming survive for so long? Apparently, our simulations usually converge.
Indicates lacking test coverage. Also reveals the vulnerability of the progress bar code...
Proposed changes
Bug: Missing break of while loop if progress bar are not turned on. Thus, the nonlinear loop continued running.
Types of changes
What types of changes does this PR introduce to PorePy? Put an
x
in the boxes that apply.Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.