The (deprecated) coarsening module has a few tests that are expected to fail. These used to be marked with @pytest.mark.skip, but this is confusing, furthermore, the test make the weekly test run (which includes skipped tests) fail. Using xfail instead should resolve this.
Proposed changes
Contributions to PorePy are highly appreciated. Clearly explain why this pull request (PR) is needed and why it should be accepted. If this PR solves an issue, explain how it is done. Please, also summarise the changes to the code.
Types of changes
What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.
[ ] Minor change (e.g., dependency bumps, broken links).
[ ] Bugfix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[x] Testing (contribution related to testing of existing or new functionality).
[ ] Documentation (contribution related to adding, improving, or fixing documentation).
The (deprecated) coarsening module has a few tests that are expected to fail. These used to be marked with
@pytest.mark.skip
, but this is confusing, furthermore, the test make the weekly test run (which includes skipped tests) fail. Using xfail instead should resolve this.Proposed changes
Contributions to PorePy are highly appreciated. Clearly explain why this pull request (PR) is needed and why it should be accepted. If this PR solves an issue, explain how it is done. Please, also summarise the changes to the code.
Types of changes
What types of changes does this PR introduce to PorePy? Put an
x
in the boxes that apply.Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.