Removed several deprecated methods from FractureNetwork2d and one unused method from FractureNetwork3d. Most of the methods have been marked for deprecation for a while, and all are almost surely never used.
Also removed an option remove_small_fractures from 2d meshing. This was not tested, and it would be surprising if the meshing is actually robust with that option active. The operation can and should be done outside the meshing routine.
Types of changes
What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.
[ ] Minor change (e.g., dependency bumps, broken links).
[ ] Bugfix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Testing (contribution related to testing of existing or new functionality).
[ ] Documentation (contribution related to adding, improving, or fixing documentation).
[x] Maintenance (e.g., improve logic and performance, remove obsolete code).
[ ] Other:
Checklist
Put an x in the boxes that apply or explain briefly why the box is not relevant.
[x] The documentation is up-to-date.
[x] Static typing is included in the update.
[x] This PR does not duplicate existing functionality.
[x] The update is covered by the test suite (including tests added in the PR).
[ ] If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.
Proposed changes
Removed several deprecated methods from
FractureNetwork2d
and one unused method fromFractureNetwork3d
. Most of the methods have been marked for deprecation for a while, and all are almost surely never used.Also removed an option
remove_small_fractures
from 2d meshing. This was not tested, and it would be surprising if the meshing is actually robust with that option active. The operation can and should be done outside the meshing routine.Types of changes
What types of changes does this PR introduce to PorePy? Put an
x
in the boxes that apply.Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.