search

pmgbergen / porepy

Python Simulation Tool for Fractured and Deformable Porous Media
GNU General Public License v3.0
248 stars 88 forks source link

Isolation of Units and conversion functionality #1247

Open jwboth opened 4 hours ago

jwboth commented 4 hours ago

As identified in #1244, an isolation of the units concept would allow for persistent use instead of attaching it both to fluids and solid etc. This is thus requested independent of the discussion in #1244.

The process shall be performed through a user project with the two tasks of 1. removing the functionality from MaterialConstants and moving to a separate Units location, and 2. updating the code base accordingly.

These changes are important for the user project #1150 on numerical constants.

vlipovac commented 2 hours ago

Is it okay to resolve this issue together with #1244 ? For practical reasons of diverging code basis.

jwboth commented 2 hours ago

Naively, I was hoping that this issue was sufficiently isolated from develop, and your changes so far (but wrongfully, I did not check the current state of your PR). For me, this sounds OK, especially taking into account your availability after next week. Please organize your time as efficiently as you can.

vlipovac commented 1 hour ago

I know it's bad practice, but this one time it will help reduce the amount of refactoring, thanks!

keileg commented 1 hour ago

Makes sense to me.