Maint_fix_minor_todos - Githubissues

IvarStefansson commented 1 month ago

Proposed changes

Resolves some todos and updates documentation.

What types of changes does this PR introduce to PorePy? Put an x in the boxes that apply.

[ ] Minor change (e.g., dependency bumps, broken links).
[ ] Bugfix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Testing (contribution related to testing of existing or new functionality).
[x] Documentation (contribution related to adding, improving, or fixing documentation).
[ ] Maintenance (e.g., improve logic and performance, remove obsolete code).
[ ] Other:

Put an x in the boxes that apply or explain briefly why the box is not relevant.

[ ] The documentation is up-to-date.
[ ] Static typing is included in the update.
[ ] This PR does not duplicate existing functionality.
[ ] The update is covered by the test suite (including tests added in the PR).
[ ] If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

keileg commented 1 month ago

I see from the tests that there was some change in the source code that I missed. Let me know if I should have a second look before merging.

IvarStefansson commented 3 weeks ago

I see from the tests that there was some change in the source code that I missed. Let me know if I should have a second look before merging.

I figured it out.