pmgbergen / porepy

Python Simulation Tool for Fractured and Deformable Porous Media
GNU General Public License v3.0
246 stars 88 forks source link

Convergence criterion #940

Open IvarStefansson opened 1 year ago

IvarStefansson commented 1 year ago

The current default convergence criterion is based on the iteration solution update. I suggest we consider replacing it with a residual based one. This might wait for the planned AD parsing overhaul which hopefully allows for evaluation of the residual without re-computing the Jacobian.

keileg commented 1 year ago

Based on input from @jwboth, we should also consider monitoring the residual for individual equations, rather than only for the full system.

IvarStefansson commented 3 months ago

This is now facilitated. Let's make a decision on whether to make residual based convergence default, @keileg and @jwboth