Is ‘split_vertices_by_face’ an essential step?

pmh47 / dirt

DIRT: a fast differentiable renderer for TensorFlow

MIT License

312 stars 63 forks source link

Is ‘split_vertices_by_face’ an essential step? #73

Closed ffiioonnaa closed 4 years ago

ffiioonnaa commented 4 years ago

Hi, I find the operation to split vertices by face made the number of vertices too much,Can I skip this step? Does this have an effect on gradient back propagation?

pmh47 commented 4 years ago

It is not required for correct gradients. It is useful if you want flat shading rather than Gouraud shading, and because dirt.matrices.vertex_normals is/was slower than dirt.matrices.vertex_normals_pre_split.

ffiioonnaa commented 4 years ago

Get it, thanks~