search

pmininni / GHOST

GHOST (the Geophysical High-Order Suite for Turbulence) is an accurate and highly scalable pseudospectral code that solves a variety of PDEs often encountered in studies of turbulent flows.
39 stars 15 forks source link

mean.eq.1 b-field update incorrect? #3

Closed s-benavides closed 4 years ago

s-benavides commented 5 years ago

Hola,

Me di cuenta que en linea 2512 de 'master' y 'pre-release-2' dice:

ifdef MAGFIELD_

           CALL rotor3(ay,az,C1,1)
           CALL rotor3(ax,az,C2,2)
           CALL rotor3(ax,ay,C3,3)

!$omp parallel do if (iend-ista.ge.nth) private (j,k) DO i = ista,iend !$omp parallel do if (iend-ista.lt.nth) private (k) DO j = 1,n DO k = 1,n M4(k,j,i) = M4(k,j,i)+vx(k,j,i) M5(k,j,i) = M5(k,j,i)+vy(k,j,i) M6(k,j,i) = M6(k,j,i)+vz(k,j,i) END DO END DO END DO

endif

Me imagino que tendria que decir:

                    M4(k,j,i) = M4(k,j,i)+C1(k,j,i)
                    M5(k,j,i) = M5(k,j,i)+C2(k,j,i)
                    M6(k,j,i) = M6(k,j,i)+C3(k,j,i)

No?

Santi

pmininni commented 4 years ago

Thanks, I just fixed this issue on 'master' and 'pre-release-2'!