search

pmint93 / helm-charts

My helm charts
https://pmint93.github.io/helm-charts/
Apache License 2.0
75 stars 74 forks source link

fix HPA api version #117

Closed Noamshmueli closed 5 months ago

Noamshmueli commented 5 months ago

fix HPA api version to autoscaling/v2

pmint93 commented 5 months ago

@Noamshmueli To keep this chart compatible with older k8s version, I suggest it detect kubernetes version and use the right apiVersion. #16 pointed out that we can use semverCompare function and .Capabilities.KubeVersion.GitVersion to do so

Noamshmueli commented 5 months ago

@pmint93 I got you and look into it but seems like autoscaling/v2 is the stable one so we can set it hradcoded

pmint93 commented 5 months ago

@pmint93 I got you and look into it but seems like autoscaling/v2 is the stable one so we can set it hradcoded

of course it is stable version, but what I mean is: autoscaling/v2 is available since v1.23, so if user running version older than v1.23 (eg: v1.22), the installation will fail

Noamshmueli commented 5 months ago

Done @pmint93