fix: add path type - Githubissues

pmint93 / helm-charts

My helm charts

https://pmint93.github.io/helm-charts/

Apache License 2.0

75 stars 74 forks source link

fix: add path type #12

Closed luisdavim closed 3 years ago

luisdavim commented 3 years ago

When I deployed this with the aws alb ingress controller, I was able to get the main html from the base path but anything under that would be a 404, it looks like if we omit the pathType it assumes ImplementationSpecific and prevents sub-paths from working, setting pathType: Prefix fixed it for me.

pmint93 commented 3 years ago

It seem pathType is a requirement since networking.k8s.io/v1. I think it's better to make this config available from values.yaml, incase of anyone want a different value than Prefix

And, please also do following to make this PR valid

Bump the chart version in Chart.yaml
Update the corresponding documents in README (if there is any)

luisdavim commented 3 years ago

I've updated the PR, I think I've covered all your comments.