search

pmint93 / helm-charts

My helm charts
https://pmint93.github.io/helm-charts/
Apache License 2.0
75 stars 74 forks source link

Allow all helm features for extraEnv values #33

Closed tessig closed 2 years ago

tessig commented 2 years ago

By just rendering extraEnv as yaml we can use all helm features like get the env value from configmaps and secrets

pmint93 commented 2 years ago

Brilliant ! @tessig

And so we can deprecate the envFromSecret for good ?

But before this PR can be merged, please also bump the chart version in Chart.yaml

tessig commented 2 years ago

@pmint93 since removing envFromSecret would be a breaking change, I suggest to first only merge this change. Or do you prefer a major version change at this point?

pmint93 commented 2 years ago

@tessig I prefer major version change

pmint93 commented 2 years ago

@tessig it seem we have problem with empty extraEnv, the result is yaml syntax error