search

pmint93 / helm-charts

My helm charts
https://pmint93.github.io/helm-charts/
Apache License 2.0
75 stars 74 forks source link

feat(config): add support for config.yaml file #45

Open hazzadous opened 2 years ago

hazzadous commented 2 years ago

Support for specifying a config.yaml config file was added here. I'm not sure if this is the best way to add support for this, but would love to have the ability to specify the databases as part of the Helm Chart values.

pmint93 commented 2 years ago

Thanks @hazzadous for contributing,

Please bump the chart version in Chart.yaml and ... From which version this config file was supported ? Can we also bump the metabase version accordingly ?

ellie commented 1 year ago

Hey @pmint93! I've bumped the chat version + would love to see this merged 🙏

From which version this config file was supported ? Can we also bump the metabase version accordingly ?

Looks like the change was added ~30 days ago: https://github.com/metabase/metabase/pull/25986

But I can't see it in the latest release :(

hazzadous commented 1 year ago

Hah thanks @ellie 🤞 it makes it in the next release. #untested

pmint93 commented 1 year ago

@hazzadous @ellie So I think we should wait for the release & official document of how to properly configure it