search

pmint93 / helm-charts

My helm charts
https://pmint93.github.io/helm-charts/
Apache License 2.0
75 stars 74 forks source link

feat: support `ServiceMonitor` #83

Closed jjangga0214 closed 1 year ago

jjangga0214 commented 1 year ago

Hi!

Currently, it provides monitoring.enabled value. However, ServiceMonitor resource for Prometheus is not provisioned. I think it's great option.

How do you think?

Thank you very much for this chart.

Sincerely,

pmint93 commented 1 year ago

@jjangga0214 Agree, but serviceMonitor should be configured with difference option than monitoring.enabled because of not everyone use prometheus operator

jjangga0214 commented 1 year ago

@pmint93 Exactly. That's the convention as well. monitoring.serviceMonitor.enabled would be cool.