search

pmint93 / helm-charts

My helm charts
https://pmint93.github.io/helm-charts/
Apache License 2.0
75 stars 74 forks source link

feat(pgbouncer): ability to disable service-account creation if alrea… #97

Closed OlivierCharuel closed 9 months ago

OlivierCharuel commented 9 months ago

This PR allows usage of the service-account features without creating it from this chart (i.e. avoid duplicate declaration, when the SA is already present in the namespace)

Thonks,

pmint93 commented 9 months ago

@OlivierCharuel the best practice is to use a field named exsistingServiceAccountName: "", then use the name if it present, otherwise use the default name. By this you can not only prevent the duplication but also use difference name for the existing service account

OlivierCharuel commented 9 months ago

@pmint93 Thanks for the advice, updated/tested my code according to your preco.