search

pmizio / typescript-tools.nvim

⚡ TypeScript integration NeoVim deserves ⚡
MIT License
1.26k stars 36 forks source link

Make node executable configurable #232

Open aromeronavia opened 5 months ago

aromeronavia commented 5 months ago

In this particular line, it's using either a cmd.exe for windows or node. I would love to have a settings for using bun as my node executable or any other custom-version node.

https://github.com/pmizio/typescript-tools.nvim/blob/master/lua/typescript-tools/process.lua#L126

I can jump into it! I would benefit from having something like this, just want to triage it first to see if that's on your roadmap

pmizio commented 5 months ago

As far as I know running tsserver in node vs bun gives no performance benefits. Even creator of bun himself stated this in some post when bun and it's performance discussion showed up(I'll try to find it).

So, no I didn't have it on my roadmap. But, I don't mind to have it as option in config defaulting into node. It should be easy to implement so if you want to jump in and do that, I'll gladly accept your pr.

aromeronavia commented 4 months ago

Great! I'll find some time in the upcoming days, thanks for the feedback!

I saw that tweet you are mentioning. For some reason at my team, by using bun we are experiencing less LSP crashes, a faster startup time and an improvement in autocomplete responses.