pmizio / typescript-tools.nvim

⚡ TypeScript integration NeoVim deserves ⚡
MIT License
1.45k stars 40 forks source link

Fix textDocument/codeLens error when a non-TS file is open #281

Closed uolot closed 2 months ago

uolot commented 3 months ago

Based on @Chaitanyabsprip comment in #280.

Fixes:

Related PRs:


On a side note, I couldn't make tests work after cloning the repo, here's the output I get:

$ make test
nvim --headless --noplugin -u tests/init.lua -c "PlenaryBustedDirectory tests/ {minimal_init = 'tests/init.lua'}"
Installing nvim-lua/plenary.nvim
Installing neovim/nvim-lspconfig
Installing nvim-treesitter/nvim-treesitter
Downloading tree-sitter-typescript...
Creating temporary directory
Extracting tree-sitter-typescript...
Compiling...
Treesitter parser for typescript has been installed
Starting...Scheduling: tests//requests_spec.lua
Scheduling: tests//editor_spec.lua
make: *** [test] Error 1
uolot commented 3 months ago

PR title check has failed, but it seems I'm not able to re-run the CI step after changing the title

KostkaBrukowa commented 2 months ago

Hey! Thanks for the PR! Commitlint fails because of the commit name: it is: fix: Fix code lens error when a non-TS file is open it should be fix: fix code lens error when a non-TS file is open (i think) If you correct the commit message I'm happy to merge this PR