search

pmlmodelling / ersem

European Regional Seas Ecosystem Model
GNU General Public License v3.0
23 stars 12 forks source link

Change rm parameter name in primary_producer.F90 #121

Closed hpowley closed 3 weeks ago

hpowley commented 6 months ago

If rm is assigned >0 in the primary_producer module, it looks like rm is being used in the _set_verticalmovement routine twice - once in pelagic base.F90 and once in primary_producer.F90 Tests indicate difference in results if the rm parameter name with primary_producer.F90 is changed and nothing else.

wathen commented 1 month ago

@glessin and @hpowley, can you look into this?

glessin commented 3 weeks ago

rm is an optional parameter in initialize_ersem_base subroutine of benthic_base.F90. The call in primary_producer.F90 does not include rm: call self%initialize_ersem_base(sedimentation=.true.) Therefore only rm defined is primary_producer.F90 is used, which is set to 0._rk by default. Case closed.