search

pmlmodelling / ersem

European Regional Seas Ecosystem Model
GNU General Public License v3.0
23 stars 12 forks source link

moved getting om_cal only if ISWCAL not equal to 0 #98

Open yutiPML opened 1 year ago

yutiPML commented 1 year ago

when ISWCAL=0 the dependency is not defined (because is not needed)

Description of Work

Fixes #95

Testing Instructions

  1. raise atmospheric pCO2 to 2000 (as the difference is noticed only for low O3_om_cal)
  2. run GOTM-ERSEM with normal fabm.yaml
  3. run GOTM-ERSEM setting ISWCAL to 0, set new parameter fdiss to the same value of fdissmin, comment definitions of parameters fdissmax, ndiss, fidssmin and the coupling to O3/om_cal
  4. compare the result (run with ISWCAL = 0 has higher bL2_c)
yutiPML commented 1 year ago

ready for review as soon as the test on pyfabm is fixed