search

pmlopes / yoke

Yoke is a middleware framework for Vert.x
http://pmlopes.github.io/yoke/
Apache License 2.0
157 stars 44 forks source link

Created simple CORS middleware #117

Closed ddossot closed 10 years ago

pmlopes commented 10 years ago

Thanks! I will merge on extras, once there is some documentation and I do some review, if there are no external dependencies on libraries I will consider merging to the main framework!

Thanks!

purplefox commented 9 years ago

David,

I would like to have CORS handling in Apex https://github.com/vert-x3/vertx-apex/tree/initial-work - would you be ok with contributing to that?

ddossot commented 9 years ago

@purplefox I would love to, only thing is that December is pretty busy so things may not move much until next year.

Also any contributor agreement and coding guidelines (style, formatting) you can point me to?

purplefox commented 9 years ago

No problem. If you are busy then I am happy to port it myself, but would need your permission to contribute it. I.e. sign the CLA :)

CLA is just the standard Eclipse one.

ddossot commented 9 years ago

I've already signed the Eclipse CLA: https://projects.eclipse.org/users/ddossot/cla (screenshot).

One thing to note: this implementation I've contributed to Yoke does not support the optional Access-Control-Max-Age feature, which you may want to add for the sake of completeness in your port. See this great flowchart for details.

purplefox commented 9 years ago

Great, thanks.