search

pmmp / BedrockProtocol

An implementation of the Minecraft: Bedrock Edition protocol in PHP
GNU Lesser General Public License v3.0
138 stars 96 forks source link

Make RequestNetworkSettingsPacket can be sent before login #176

Closed DavyCraft648 closed 1 year ago

dktapps commented 1 year ago

Not sure why you need this. PM only checks it for clientbound packets anyway.

DavyCraft648 commented 1 year ago

I'm using https://github.com/ipad54/BedrockEditionClient to debug some stuff on the server.

PM only checks it for clientbound packets anyway.

Even so, pm sets canBeSentBeforeLogin() to true in the ClientToServerHandshake packet. So it feels valid if it's in the RequestNetworkSettings packet too.