pmmp / BedrockProtocol

An implementation of the Minecraft: Bedrock Edition protocol in PHP
GNU Lesser General Public License v3.0
135 stars 91 forks source link

Add a default message value to DisconnectPacket #224

Closed BrandPVP closed 6 months ago

BrandPVP commented 6 months ago

When you decode this packet and want to get the message property, it will throw an error if it's not initialized and there is no way to check it

dktapps commented 6 months ago

It should be set to null in decodePayload, not here

BrandPVP commented 6 months ago

done?

dktapps commented 6 months ago

Thanks!