Remove COLOUR alias in EntityMetadataProperties for consistency

pmmp / BedrockProtocol

An implementation of the Minecraft: Bedrock Edition protocol in PHP

GNU Lesser General Public License v3.0

137 stars 96 forks source link

Remove COLOUR alias in EntityMetadataProperties for consistency #3

Closed inxomnyaa closed 3 years ago

inxomnyaa commented 3 years ago

Description

POTION_COLOR and COLOR_2 also have no alias. To prevent a mix of COLOR and COLOUR in PMMP, it is advised to remove the BE variant instead

This might break some plugins that use the COLOUR constant.

Justification

dylan agreed🙃

dktapps commented 3 years ago

For posterity: While I dislike American English (AE), it's preferable to always consistently use AE rather than mix AE and BE, for the sake of consistency and guessability. Since switching to BE would unnecessarily break a bunch of stuff (PM and its libraries already mostly use AE), we should stick consistently with AE.