Closed kaozaza2 closed 2 years ago
Ignore my approval... This is an API break. Users may want to call $vector2->add($vector2)
. Why would you have to stop this functionality? Do we have another function to replace this direct call?
distanceSquared already implements the same overloaded logic.
I'm more leaning towards getting rid of the overloaded logic entirely, rather than doing this. It's really not that difficult to do vector->distance(new Vector2(x, y))
if you want to pass two floats.
I should also mention that Vector3 doesn't have this overloading, so there's an inconsistency to confuse developers.
Remove unused code