pmmp / Math

PHP library containing math related code used in PocketMine-MP
GNU Lesser General Public License v3.0
41 stars 22 forks source link

Implement Vector3::maxComponents and Vector3::minComponents #6

Closed CortexPE closed 5 years ago

CortexPE commented 5 years ago

In comparison to #5, this implementation allows for an indefinite count of vectors to be passed, instead of being limited on just two.

dktapps commented 5 years ago

Please add unit tests so that we can see this is working as intended.

dktapps commented 5 years ago

I think this is good to merge now. @SOF3 do you want to re-review?