search

pmmp / Math

PHP library containing math related code used in PocketMine-MP
GNU Lesser General Public License v3.0
41 stars 20 forks source link

Facing and Axis to enum #91

Open Dhaiven opened 9 months ago

Dhaiven commented 9 months ago

Fix #89

This change requires many changes in pmmp. I can do if this pr is good for you.

dktapps commented 9 months ago

If we're going with enums I would prefer to ditch the numeric values entirely. They have no purpose except to be implicitly misused as Minecraft constants.

Dhaiven commented 9 months ago

If we're going with enums I would prefer to ditch the numeric values entirely. They have no purpose except to be implicitly misused as Minecraft constants.

Should I do the same for Axis? I don't know if these values ​​represent anything or not

dktapps commented 9 months ago

If we're going with enums I would prefer to ditch the numeric values entirely. They have no purpose except to be implicitly misused as Minecraft constants.

Should I do the same for Axis? I don't know if these values ​​represent anything or not

Yes

Dhaiven commented 4 months ago

This pr is good ? if yes i can change pocketmine to support Facing enum