Saplings Do Not Need Space To Grow

Haxley commented 6 years ago

Issue description

Saplings do not need adjacent space to grow. Saplings can grow trees touching each other without space in between them.

Expected result: What were you expecting to happen? Expecting saplings needed adjacent space to grow.
Actual result: What actually happened? Saplings do not need adjacent space to grow.

Steps to reproduce the issue

... Plant saplings next to eachother.
... Use bone meal to make them grow.
... Observe them not needing adjacent space to grow.

OS and versions

PocketMine-MP: 1.7dev-516
PHP: 7
Server OS: Linux
Game version: PE/Win10

Plugins

Test on a clean server without plugins: is the issue reproducible without any plugins loaded? Same results on clean server.

If the issue is not reproducible without plugins:

Have you asked for help on our forums before creating an issue?
Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section
Paste your list of plugins here (use the 'plugins' command in PocketMine-MP)

Crashdump, backtrace or other files

Do not paste crashdumps into an issue - please use our Crash Archive at https://crash.pmmp.io for submitting crash reports to not spam the issue tracker. Add links to your reports in the Crash Archive here.
Please use gist or anything else to add other files and add links here
...

Haxley commented 6 years ago

@dktapps https://youtu.be/kLyQZF3Os0M Sorry for watermark.

dktapps commented 6 years ago

no worries. It's only unconfirmed because I haven't had time to investigate or reproduce this yet.

dktapps commented 6 years ago

This actually behaves the same way in vanilla PC:

However, PocketMine-MP does not account for a) light level (which has to be >= 8), and b) randomness when using bonemeal (not implemented).

dktapps commented 6 years ago

and also in vanilla PE as it happens:

Closing this since it matches vanilla behaviour. Some other tweaks do need to be made, but this issue is invalid.

Haxley commented 6 years ago

@dktapps I realize that my video is in creative mode and that's probably what you're testing in. I'm actually referring to survival mode. I thought creative wasn't supposed to allow growing trees adjacent to one another but it does. Everyone who plays single-player on PE cannot grow trees adjacent to each other, unless it's a 2x2 tree or creative mode. I can't speak for Java but if so, it's probably not working as intended (or in creative mode) as every web search returns requirements for tree spacing. Tree farms on my server literally look like huge solid log blocks.

JackNoordhuis commented 6 years ago

@Haxley it is possible to grow trees in vanilla bedrock survival directly next to each other with bonemeal (a lot of it at that) however, the chances of it happening naturally would be extremely low. I haven't tested it on the Java edition or taken the time to see if it can happen naturally but testing it on PE survival with bonemeal works fine.

Haxley commented 6 years ago

@jacknoordhuis By vanilla do you mean really old original Minecraft, or do you mean unmodified Minecraft as it was intended to play. If it’s the latter, you definitely cannot grow trees adjacent to each other in survival PE.

Ifera commented 6 years ago

Yea you can't but with bonemeal you can.. EOD.

dktapps commented 6 years ago

With normal growth it's dependent on light levels. Saplings under trees don't grow because they don't have sufficient light available, not because there is not sufficient space.

I tested this in both creative and survival, and also looked at reverse engineered PC code to verify. Sorry, but you're simply wrong.

pmmp / PocketMine-MP