search

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.28k stars 1.56k forks source link

Sign can be places on top of a painting #2363

Open Philipp97714 opened 6 years ago

Philipp97714 commented 6 years ago

Signs can be placed on top of a painting which should not be possible. Also building secret doors like here: https://youtu.be/yuZcjtcwqy0?t=49s isn't possible.

Tested with 3.1.3

Philipp97714 commented 6 years ago

Here is a screenshot: https://photos.app.goo.gl/x7vFfYQBw6T6gdFx6

dktapps commented 6 years ago

PocketMine-MP doesn't consider signs as solid. Paintings require a solid material backing them, so this prevents the placement.

Philipp97714 commented 6 years ago

Additional to the not possible placement, putting signs in front of a picture should not be possible. Take a look at the screen shot for more details

dktapps commented 5 years ago

For what it's worth, the signs overlapping with paintings thing also works in vanilla MCPE, so that's not a valid bug.

The placement bug in front of doors comes from the problem that solid == can be collided with in PM. PM doesn't make any distinction between blocks which are solid but can't be collided with (pressure plate, sign etc). The closest we have right now is canBeFlowedInto() but that's not the most intuitive solution, although I suppose it'll do for a patch release.