search

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.28k stars 1.56k forks source link

Illager banner in creative inventory places a normal white banner #2951

Open dktapps opened 5 years ago

dktapps commented 5 years ago

Issue description

Illager banner appears to use a non-standard method to define its pattern in NBT, which is not recognized by PM. This leads to the placement of a regular white banner when placing an illager banner.

This is considered a bug because the item appears in the creative inventory, but doesn't work as designed.

Steps to reproduce the issue

  1. Get an illager banner from the creative inventory.
  2. Place it and notice it turns white.

OS and versions

Wertzui123 commented 5 years ago

I noticed that too 🤔

Jean-TKG commented 5 years ago

can't we not just add in src/pocketmine/tile/Banner.php PATTERN_ILLAGER and add the colors to it

dktapps commented 5 years ago

No, it's not that simple. Mojang specialized this one for reasons I'm not clear on.

Jean-TKG commented 5 years ago

oh ok

Wertzui123 commented 5 years ago

Okey.

dktapps commented 1 year ago

With the new serializer architecture in PM5, it should be possible to implement this as a separate item, avoiding the conditionally useless / broken pattern APIs for illager banners.