Landing sounds are played in spectator mode

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.26k stars 1.53k forks source link

Landing sounds are played in spectator mode #3516

Closed dktapps closed 3 years ago

dktapps commented 4 years ago

Issue description

Recently on PM4, landing sounds became server-sided. However, they don't take into account that spectator players should make no noise (and nor do they take the SILENT data flag into effect).

Steps to reproduce the issue

Switch to spectator mode
Fly down through a block

OS and versions

PocketMine-MP: 3bb53658daf73f2f19f31bfd16377cbf3e6b968f
PHP: 7.3.16
Server OS: windows
Game version: Win10

Gianluxx commented 4 years ago

On PM3 when a spectator hits air or an entity. Other players can hear the noise and the DamageEvent is actually called

dktapps commented 4 years ago

The damage event is supposed to be called. It's cancelled by default.

Gianluxx commented 4 years ago

what about the sound?