Commands Are not disabled after plugin disable (PluginIdentifiableCommand) - Githubissues

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.27k stars 1.54k forks source link

Commands Are not disabled after plugin disable (PluginIdentifiableCommand) #3531

Closed Kjenium closed 4 years ago

Kjenium commented 4 years ago

Issue description

Expected result: What were you expecting to happen? I expected to see the command disabled
Actual result: What actually happened? It is still registered and can be executable

Steps to reproduce the issue

Make your plugin crash with an error
Perform a command registered by it

OS and versions

PocketMine-MP: 3.12.2
PHP: 7.x.x
Server OS: I'm using a web platform so idk
Game version: PE/Win10 (delete as appropriate)

Plugins

If you remove all plugins, does the issue still occur? yes
If the issue is not reproducible without plugins:
- Have you asked for help on our forums before creating an issue?
- Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section

Crashdump, backtrace or other files

xerenahmed commented 4 years ago

With which code do you close the plugin?

dktapps commented 4 years ago

"crashing by error" causes the server to enter undefined state. Simply don't crash in the first place.