"Switching" isn't fixed

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.25k stars 1.53k forks source link

"Switching" isn't fixed #3558

Closed ghost closed 4 years ago

ghost commented 4 years ago

Issue description

The bug that was described in #2939 was not fixed (check video)

OS and versions

PocketMine-MP: 3.13.0
PHP: 7.3.18
Server OS: Debian 10
Game version: Windows 10

Plugins

Plugins (0):

Crashdump, backtrace or other files

Video: https://youtu.be/8ZnYBzbCBE4

dktapps commented 4 years ago

You're switching between two tools with different levels if damage. Therefore, this is WAI; the difference is that the lower previous damage is subtracted from the higher damage if it's bypassing a cooldown, so that the damage isn't overpowered anymore.

Nerahikada commented 4 years ago

This may be compliant with vanilla behavior, but this was not what we I wanted :joy:

dktapps commented 4 years ago

If you want something else, you can do it yourself with a plugin.

Nerahikada commented 2 months ago

finally fixed(?) with this commit: d70a7d34a7f70b9d7325d168fa43ba30382ba640