search

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.27k stars 1.54k forks source link

Players take a large amount of fall damage when comboed #3866

Closed buchwasa closed 4 years ago

buchwasa commented 4 years ago

Issue description

Steps to reproduce the issue

  1. Join with a friend
  2. Combo them for a while (10-15s is a good amount)
  3. Stop, and let them take fall damage

OS and versions

Plugins

Can be done without plugins

Crashdump, backtrace or other files

dktapps commented 4 years ago

For posterity: My theory for this behaviour is that comboing prevents the player from touching the ground for a while, and the downwards movements they make while being comboed all stack together, while the upwards movements have no effect.

ZizzyZizzy commented 4 years ago

@dktapps I've seen this exact behavior when testing the limits of hacked clients and anti-cheat plugins.

One of the hacks that lets you fly on a PMMP server with anti-cheat still keeps adding the height every time you "air jump", so even if you're 1/2 block up from the last air jump, you still die from falling. The only way to prevent the death is to land in water.

dktapps commented 4 years ago

Yeah, I've noticed the same, but I didn't think anything of it because I didn't realize it might occur in non-cheat scenarios.