search

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.28k stars 1.56k forks source link

Dropped items don't get pushed out of a block if standing inside the northern or western edge #3929

Open TheNewHEROBRINEX opened 4 years ago

TheNewHEROBRINEX commented 4 years ago

Issue description

Steps to reproduce the issue

  1. Build a pillar of blocks
  2. Break one of the blocks
  3. Drop an item on an edge of the block that is below the one you broke (I was able to reproduce this only on north and west directions)
  4. Place back the block you broke in step 2
  5. Notice that the item doesn't fall

OS and versions

Plugins

Crashdump, backtrace or other files

Images showing the issue: https://imgur.com/a/l7FQstv

dktapps commented 4 years ago

I don't think this is actually a bug. The code responsible for the pushing is working fine. It's just not doing what you expect it to.

The position of the item entity is outside of the block. It's already technically "pushed out" by that measure. It's just lodged where it is because the AABB is partly colliding with the block below it.

TheNewHEROBRINEX commented 4 years ago

I think that if the item entity is outside of the first block it should also be able to free fall without colliding with the blocks below since the two blocks are aligned one on top of each other.

dktapps commented 4 years ago

Sure. I'm just saying that the current code is doing exactly what it was intended to, despite the fact it's not exactly logical.

ghost commented 3 years ago

no