server.log system like Bukkit

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.28k stars 1.56k forks source link

server.log system like Bukkit #4029

Closed AkmalFairuz closed 8 months ago

AkmalFairuz commented 3 years ago

Description

Move server.log to logs/ new folder.
Backup and compress server.log to .gz every 1 day and rename to date format then create new server.log.

Justification

Easy find error and lower disk usage.

Alternative methods

SOF3 commented 3 years ago

Also suggested in old repo: https://github.com/PocketMine/PocketMine-MP/pull/3146

dktapps commented 3 years ago

I don't think a daily log suits. In many cases it would just fill the disk with tiny archives. The solution I was considering is to archive it when it reaches a certain size.

SOF3 commented 3 years ago

Edit: this was the original issue. https://github.com/PocketMine/PocketMine-MP/issues/3079#issue-82365382

KygekDev commented 3 years ago

I don't think a daily log suits. In many cases it would just fill the disk with tiny archives. The solution I was considering is to archive it when it reaches a certain size.

Yes, that's a better idea

dktapps commented 8 months ago

Implemented by #4032, minus the compression step. (Due to performance considerations, I figured it made more sense to let the user configure external tools like cron to delete or compress the files as they see fit.)