Dragon Egg is not destroyed - Githubissues

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.27k stars 1.54k forks source link

Dragon Egg is not destroyed #4179

Closed alvin0319 closed 3 years ago

alvin0319 commented 3 years ago

Issue description

Expected result: What were you expecting to happen? Dragon Egg is destroyed
Actual result: What actually happened? Dragon Egg is not destroyed and teleported somewhere

Vanilla behavior

https://user-images.githubusercontent.com/32565818/115112786-26e5d380-9fc2-11eb-94e1-76fe58269c62.mp4

PMMP behavior

https://user-images.githubusercontent.com/32565818/115112807-32d19580-9fc2-11eb-96dc-ddd7e057ea50.mp4

Steps to reproduce the issue

Place Dragon Egg
Try to destroy Dragon Egg

OS and versions

PocketMine-MP: a32eb4ebc3e82d52cd44d4dc03dcd59a965ed75c
PHP: 7.4
Server OS: Windows
Game version: PE/Win10

Plugins

If you remove all plugins, does the issue still occur?
If the issue is not reproducible without plugins:
- Have you asked for help on our forums before creating an issue?
- Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section

Crashdump, backtrace or other files

Mohagames205 commented 3 years ago

Yeah that's because pocketmine doesn't check what gamemode the player is in. So, the exact behavior should be

Creative:

Right click = teleport
Left click = break

https://github.com/pmmp/PocketMine-MP/blob/master/src/block/DragonEgg.php#L59-L62

public function onAttack(Item $item, int $face, ?Player $player = null) : bool{
        $this->teleport();
        return true;
}