pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.26k stars 1.54k forks source link

Chat sent by players will be translated #4371

Closed Nerahikada closed 3 years ago

Nerahikada commented 3 years ago

Issue description

Steps to reproduce the issue

  1. Send chat "%language.name".
  2. It will display "English" instead of "%language.name"

OS and versions

Plugins

[20:54:40.541] [Server thread/INFO]: Plugins (0):

Crashdump, backtrace or other files

dktapps commented 3 years ago

I guess this happens because of this code: https://github.com/pmmp/PocketMine-MP/blob/789a669395a0d4d9e2ca59b3244e41f3ff05b5b3/src/player/Player.php#L1781

There are still some things implicitly depending on this translation behaviour, such as HelpCommand, which embeds untranslated translation keys into raw messages. Until these cases are fixed, this issue will remain.

dktapps commented 3 years ago

Fixed by https://github.com/pmmp/PocketMine-MP/commit/5da90b9530c4100cd7c3971675faea74f27b5438 (and the preceding commits).