Preprocessor submodule on master branch uses an outdated version

jasonw4331 commented 3 years ago

Issue description

The preprocessor submodule on the master branch uses an outdated commit which causes a crash on launch when following the BUILDING.md

Steps to reproduce the issue

Follow the steps listed in the BUILDING.md file

OS and versions

PocketMine-MP: 4189fbdaefd5f73485b64c0cc9509d8ad0479f5f

Plugins

If you remove all plugins, does the issue still occur? Yes
If the issue is not reproducible without plugins:
- Have you asked for help on our forums before creating an issue?
- Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section

Crashdump, backtrace or other files

[02:12:14.765] [Server thread/CRITICAL]: Could not execute asynchronous task LightPopulationTask: Task crashed
[02:12:14.864] [AsyncWorker#0 thread/CRITICAL]: Error: "Undefined constant pocketmine\world\World::HALF_Y_MAX" (EXCEPTION) in "pmsrc/src/world/light/LightUpdate" at line 96
[02:12:14.864] [AsyncWorker#0 thread/CRITICAL]: #0 pmsrc/src/world/light/SkyLightUpdate(154): pocketmine\world\light\LightUpdate->setAndUpdateLight(integer 0, integer 63, integer 0, integer 15)
[02:12:14.864] [AsyncWorker#0 thread/CRITICAL]: #1 pmsrc/src/world/light/LightPopulationTask(69): pocketmine\world\light\SkyLightUpdate->recalculateChunk(integer 0, integer 0)
[02:12:14.864] [AsyncWorker#0 thread/CRITICAL]: #2 pmsrc/src/scheduler/AsyncTask(84): pocketmine\world\light\LightPopulationTask->onRun()
[02:12:14.864] [AsyncWorker#0 thread/CRITICAL]: #3 (): pocketmine\scheduler\AsyncTask->run()

dktapps commented 3 years ago

Fixed by 239534995fdbefac4d75ab8e1cd9a492b38b7f40.

KMatuszak commented 3 years ago

Now it crashes server on join:

[16:18:20.772] [Server thread/CRITICAL]: Error: "Call to undefined method pocketmine\world\format\Chunk::getBlockLight()" (EXCEPTION) in "pmsrc/src/world/World" at line 1310
[16:18:20.773] [Server thread/CRITICAL]: #0 pmsrc/src/block/Grass(74): pocketmine\world\World->getFullLightAt(integer 245, integer 64, integer 266)
[16:18:20.773] [Server thread/CRITICAL]: #1 pmsrc/src/world/World(1094): pocketmine\block\Grass->onRandomTick()
[16:18:20.773] [Server thread/CRITICAL]: #2 pmsrc/src/world/World(1006): pocketmine\world\World->tickChunk(integer 15, integer 16)
[16:18:20.773] [Server thread/CRITICAL]: #3 pmsrc/src/world/World(841): pocketmine\world\World->tickChunks()
[16:18:20.774] [Server thread/CRITICAL]: #4 pmsrc/src/world/World(756): pocketmine\world\World->actuallyDoTick(integer 1424)
[16:18:20.774] [Server thread/CRITICAL]: #5 pmsrc/src/world/WorldManager(335): pocketmine\world\World->doTick(integer 1424)
[16:18:20.774] [Server thread/CRITICAL]: #6 pmsrc/src/Server(1614): pocketmine\world\WorldManager->tick(integer 1424)
[16:18:20.774] [Server thread/CRITICAL]: #7 pmsrc/src/Server(1518): pocketmine\Server->tick()
[16:18:20.775] [Server thread/CRITICAL]: #8 pmsrc/src/Server(1075): pocketmine\Server->tickProcessor()
[16:18:20.775] [Server thread/CRITICAL]: #9 pmsrc/src/PocketMine(300): pocketmine\Server->__construct(object BaseClassLoader#3, object pocketmine\utils\MainLogger#2, string[10] /root/kek/, string[18] /root/kek/plugins/)
[16:18:20.775] [Server thread/CRITICAL]: #10 pmsrc/src/PocketMine(323): pocketmine\server()
[16:18:20.775] [Server thread/CRITICAL]: #11 pmsrc(11): require(string[54] phar:///root/kek/PocketMine-MP.phar/src/PocketMine.php)
[16:18:20.776] [Server thread/EMERGENCY]: An unrecoverable error has occurred and the server has crashed. Creating a crash dump
[16:18:20.781] [Server thread/EMERGENCY]: Please upload the "/root/kek/crashdumps/Thu_Aug_26-16.18.20-UTC_2021.log" file to the Crash Archive and submit the link to the Bug Reporting page. Give as much info as you can.

dktapps commented 3 years ago

Maybe we should just drop PreProcessor entirely ... it's more trouble than it's worth any time a small change occurs.

pmmp / PocketMine-MP